Skip to content

Fix broken generator tests, updates to go.sum needed#25251

Merged
kvch merged 1 commit intoelastic:masterfrom
andrewkroh:bugfix/generators-go-sum
Apr 23, 2021
Merged

Fix broken generator tests, updates to go.sum needed#25251
kvch merged 1 commit intoelastic:masterfrom
andrewkroh:bugfix/generators-go-sum

Conversation

@andrewkroh
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh commented Apr 22, 2021 •
edited
Loading

What does this PR do?

Both generator tests were failing because the go.sum needed an update after running mage test.
The tools.go file was not updated to include gotest.tools/gotestsum/cmd which is installed while
running mage test.

The original errors were:

go: updates to go.sum needed, disabled by -mod=readonly
Error: running "go build -o build/golang-crossbuild/testbeat-windows-amd64.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
Error: failed building for windows/amd64: exit status 1
failed building for windows/amd64: exit status 1

go: updates to go.sum needed, disabled by -mod=readonly
Error: running "go build -o build/golang-crossbuild/testbeat-windows-386.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
Error: failed building for windows/386: exit status 1
failed building for windows/386: exit status 1

Why is it important?

master build is red.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@andrewkroh
Fix broken generator tests, updates to go.sum needed
71dc94b 
Both generator tests were failing because the go.sum needed an update after running `mage test`.
The tools.go file was not updated to include gotest.tools/gotestsum/cmd which is installed while
running `mage test`.

The original errors were:
    go: updates to go.sum needed, disabled by -mod=readonly
    Error: running "go build -o build/golang-crossbuild/testbeat-windows-amd64.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
    Error: failed building for windows/amd64: exit status 1
    failed building for windows/amd64: exit status 1

    go: updates to go.sum needed, disabled by -mod=readonly
    Error: running "go build -o build/golang-crossbuild/testbeat-windows-386.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
    Error: failed building for windows/386: exit status 1
    failed building for windows/386: exit status 1
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 22, 2021
@andrewkroh andrewkroh added :Generator Related to code generators for building custom Beats or modules. review Team:Elastic-Agent Label for the Agent team labels Apr 23, 2021
@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 23, 2021
@andrewkroh andrewkroh marked this pull request as ready for review April 23, 2021 00:19
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 23, 2021

Pinging @elastic/agent (Team:Agent)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 23, 2021

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh mentioned this pull request Apr 23, 2021
Merged
2 tasks
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 23, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25251 opened

  • Start Time: 2021-04-22T23:53:07.723+0000

  • Duration: 29 min 5 sec

  • Commit: 71dc94b

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

@kvch kvch merged commit 542bef8 into elastic:master Apr 23, 2021
@urso
Copy link
Copy Markdown

urso commented Apr 23, 2021

Please backport to 7.x, 7.13, and 7.12

@andrewkroh andrewkroh added backport-v7.12.0 Automated backport with mergify backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify labels Apr 23, 2021
mergify Bot pushed a commit that referenced this pull request Apr 23, 2021
@andrewkroh
Fix broken generator tests, updates to go.sum needed (#25251)
7ed24ed 
Both generator tests were failing because the go.sum needed an update after running `mage test`.
The tools.go file was not updated to include gotest.tools/gotestsum/cmd which is installed while
running `mage test`.

The original errors were:
    go: updates to go.sum needed, disabled by -mod=readonly
    Error: running "go build -o build/golang-crossbuild/testbeat-windows-amd64.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
    Error: failed building for windows/amd64: exit status 1
    failed building for windows/amd64: exit status 1

    go: updates to go.sum needed, disabled by -mod=readonly
    Error: running "go build -o build/golang-crossbuild/testbeat-windows-386.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
    Error: failed building for windows/386: exit status 1
    failed building for windows/386: exit status 1

(cherry picked from commit 542bef8)
@mergify mergify Bot mentioned this pull request Apr 23, 2021
Merged
mergify Bot pushed a commit that referenced this pull request Apr 23, 2021
@andrewkroh
Fix broken generator tests, updates to go.sum needed (#25251)
f083999 
Both generator tests were failing because the go.sum needed an update after running `mage test`.
The tools.go file was not updated to include gotest.tools/gotestsum/cmd which is installed while
running `mage test`.

The original errors were:
    go: updates to go.sum needed, disabled by -mod=readonly
    Error: running "go build -o build/golang-crossbuild/testbeat-windows-amd64.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
    Error: failed building for windows/amd64: exit status 1
    failed building for windows/amd64: exit status 1

    go: updates to go.sum needed, disabled by -mod=readonly
    Error: running "go build -o build/golang-crossbuild/testbeat-windows-386.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
    Error: failed building for windows/386: exit status 1
    failed building for windows/386: exit status 1

(cherry picked from commit 542bef8)
@mergify mergify Bot mentioned this pull request Apr 23, 2021
Merged
mergify Bot pushed a commit that referenced this pull request Apr 23, 2021
@andrewkroh
Fix broken generator tests, updates to go.sum needed (#25251)
a80cc9d 
Both generator tests were failing because the go.sum needed an update after running `mage test`.
The tools.go file was not updated to include gotest.tools/gotestsum/cmd which is installed while
running `mage test`.

The original errors were:
    go: updates to go.sum needed, disabled by -mod=readonly
    Error: running "go build -o build/golang-crossbuild/testbeat-windows-amd64.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
    Error: failed building for windows/amd64: exit status 1
    failed building for windows/amd64: exit status 1

    go: updates to go.sum needed, disabled by -mod=readonly
    Error: running "go build -o build/golang-crossbuild/testbeat-windows-386.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
    Error: failed building for windows/386: exit status 1
    failed building for windows/386: exit status 1

(cherry picked from commit 542bef8)
@mergify mergify Bot mentioned this pull request Apr 23, 2021
Merged
andrewkroh added a commit that referenced this pull request Apr 23, 2021
@mergify @andrewkroh
Fix broken generator tests, updates to go.sum needed (#25251) (#25268)
de5a23f 
Both generator tests were failing because the go.sum needed an update after running `mage test`.
The tools.go file was not updated to include gotest.tools/gotestsum/cmd which is installed while
running `mage test`.

The original errors were:
    go: updates to go.sum needed, disabled by -mod=readonly
    Error: running "go build -o build/golang-crossbuild/testbeat-windows-amd64.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
    Error: failed building for windows/amd64: exit status 1
    failed building for windows/amd64: exit status 1

    go: updates to go.sum needed, disabled by -mod=readonly
    Error: running "go build -o build/golang-crossbuild/testbeat-windows-386.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
    Error: failed building for windows/386: exit status 1
    failed building for windows/386: exit status 1

(cherry picked from commit 542bef8)

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
andrewkroh added a commit that referenced this pull request Apr 23, 2021
@mergify @andrewkroh
Fix broken generator tests, updates to go.sum needed (#25251) (#25269)
df04b93 
Both generator tests were failing because the go.sum needed an update after running `mage test`.
The tools.go file was not updated to include gotest.tools/gotestsum/cmd which is installed while
running `mage test`.

The original errors were:
    go: updates to go.sum needed, disabled by -mod=readonly
    Error: running "go build -o build/golang-crossbuild/testbeat-windows-amd64.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
    Error: failed building for windows/amd64: exit status 1
    failed building for windows/amd64: exit status 1

    go: updates to go.sum needed, disabled by -mod=readonly
    Error: running "go build -o build/golang-crossbuild/testbeat-windows-386.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
    Error: failed building for windows/386: exit status 1
    failed building for windows/386: exit status 1

(cherry picked from commit 542bef8)

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
andrewkroh added a commit that referenced this pull request Apr 23, 2021
@mergify @andrewkroh
Fix broken generator tests, updates to go.sum needed (#25251) (#25270)
d6a5098 
Both generator tests were failing because the go.sum needed an update after running `mage test`.
The tools.go file was not updated to include gotest.tools/gotestsum/cmd which is installed while
running `mage test`.

The original errors were:
    go: updates to go.sum needed, disabled by -mod=readonly
    Error: running "go build -o build/golang-crossbuild/testbeat-windows-amd64.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
    Error: failed building for windows/amd64: exit status 1
    failed building for windows/amd64: exit status 1

    go: updates to go.sum needed, disabled by -mod=readonly
    Error: running "go build -o build/golang-crossbuild/testbeat-windows-386.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
    Error: failed building for windows/386: exit status 1
    failed building for windows/386: exit status 1

(cherry picked from commit 542bef8)

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@mergify @andrewkroh
Fix broken generator tests, updates to go.sum needed (elastic#25251) (e…
20a42e1 
…lastic#25270)

Both generator tests were failing because the go.sum needed an update after running `mage test`.
The tools.go file was not updated to include gotest.tools/gotestsum/cmd which is installed while
running `mage test`.

The original errors were:
    go: updates to go.sum needed, disabled by -mod=readonly
    Error: running "go build -o build/golang-crossbuild/testbeat-windows-amd64.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
    Error: failed building for windows/amd64: exit status 1
    failed building for windows/amd64: exit status 1

    go: updates to go.sum needed, disabled by -mod=readonly
    Error: running "go build -o build/golang-crossbuild/testbeat-windows-386.exe -buildmode pie -ldflags -s -extldflags=-Wl,--nxcompat -X github.com/elastic/beats/v7/libbeat/version.buildTime=2021-04-22T20:49:55Z -X github.com/elastic/beats/v7/libbeat/version.commit=c3a7a6abdf2a15cfd685e82ce1fe502296509825" failed with exit code 1
    Error: failed building for windows/386: exit status 1
    failed building for windows/386: exit status 1

(cherry picked from commit c67d161)

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kvch kvch kvch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport-v7.12.0 Automated backport with mergify backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify :Generator Related to code generators for building custom Beats or modules. review Team:Elastic-Agent Label for the Agent team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewkroh @elasticmachine @urso @kvch